Skip to content

Delete remove defaults channel step from test_windows job#1886

Merged
oleksandr-pavlyk merged 2 commits into
masterfrom
fix-workflow-step-test-windows
Nov 7, 2024
Merged

Delete remove defaults channel step from test_windows job#1886
oleksandr-pavlyk merged 2 commits into
masterfrom
fix-workflow-step-test-windows

Conversation

@oleksandr-pavlyk

Copy link
Copy Markdown
Contributor

The setup-miniconda action is removing 'defaults' channels now, and attempt at repeated removal trips an error.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Comment thread .github/workflows/conda-package.yml
@github-actions

github-actions Bot commented Nov 6, 2024

Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions

github-actions Bot commented Nov 6, 2024

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_171 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@coveralls

coveralls commented Nov 6, 2024

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 87.686%. remained the same
when pulling 24dfea8 on fix-workflow-step-test-windows
into 7ffcca4 on master.

@github-actions

github-actions Bot commented Nov 6, 2024

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_172 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndgrigorian ndgrigorian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants