Skip to content

Parametrise target#10

Merged
JSv4 merged 3 commits into
JSv4:mainfrom
ross-mcnairn-dev:parametrise_target
Jun 24, 2024
Merged

Parametrise target#10
JSv4 merged 3 commits into
JSv4:mainfrom
ross-mcnairn-dev:parametrise_target

Conversation

@ross-mcnairn-dev
Copy link
Copy Markdown
Contributor

@ross-mcnairn-dev ross-mcnairn-dev commented May 31, 2024 •
edited
Loading

In certain runtimes (AWS Lambda in my case), we are quite restricted on where we can write files. When we extract the compressed binaries and write them to the filesystem, they need to be written under /tmp in Lambda, as that's the only writeable filesystem.

So, here I'm parametrising the target path.

@ross-mcnairn-dev
Copy link
Copy Markdown
Contributor Author

ross-mcnairn-dev commented May 31, 2024 •
edited
Loading

Sorrry I did something dumb - I opened up the original PR against main so now this is stacked on main w/ the changes from the other PR - I'll set this PR to draft for now. If the other ARM PR looks good then i'll update the base after merging it and then this will be ready for review.

@ross-mcnairn-dev ross-mcnairn-dev marked this pull request as draft May 31, 2024 14:09
@JSv4
Copy link
Copy Markdown
Owner

JSv4 commented Jun 4, 2024

@ross-mcnairn-dev, merged your ARM branch. Thanks for that and sorry for the delay.

@ross-mcnairn-dev
Copy link
Copy Markdown
Contributor Author

ross-mcnairn-dev commented Jun 4, 2024

@ross-mcnairn-dev, merged your ARM branch. Thanks for that and sorry for the delay.

Hey, no worries at all! Happy to be able to make a small contribution here :). I'll clean this one up and open it tonight.

@ross-mcnairn-dev ross-mcnairn-dev marked this pull request as ready for review June 4, 2024 18:03
@ross-mcnairn-dev
Copy link
Copy Markdown
Contributor Author

ross-mcnairn-dev commented Jun 4, 2024

OK, @JSv4 no rush on this, but this is ready for review when you've got a few this week

@ross-mcnairn-dev
Copy link
Copy Markdown
Contributor Author

ross-mcnairn-dev commented Jun 24, 2024

Hey @JSv4 , do you think you'd have time to review this this week?

JSv4
JSv4 reviewed Jun 24, 2024
View reviewed changes
Copy link
Copy Markdown
Owner

@JSv4 JSv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding

@JSv4 JSv4 merged commit 254e742 into JSv4:main Jun 24, 2024
@JSv4
Copy link
Copy Markdown
Owner

JSv4 commented Jun 24, 2024

Thanks for the reminder @ross-mcnairn-dev

@rishabh-sagar-20
Copy link
Copy Markdown
Contributor

rishabh-sagar-20 commented Jul 5, 2024

This is great @ross-mcnairn-dev @JSv4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSv4 JSv4 JSv4 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ross-mcnairn-dev @JSv4 @rishabh-sagar-20