WIP define identity projections for subspaces#390
Closed
oxinabox wants to merge 1 commit into
Closed
Conversation
Member
Author
|
I think probably this would be a lot simpler if it didn't try and do it all in post process and adding methods but rather did it as part of the definitions in the main section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is attempting to bring in the simplications for subspaces discussed in JuliaDiff/ChainRules.jl#467
It is uglier than I had expected.
Maybe because I am trying to be too general
Currently it errors bit it is just a sketch