Skip to content

Type-stable compress and random order in benchmarks#198

Merged
gdalle merged 3 commits into
mainfrom
gd/typestab_compress
Mar 5, 2025
Merged

Type-stable compress and random order in benchmarks#198
gdalle merged 3 commits into
mainfrom
gd/typestab_compress

Conversation

@gdalle

@gdalle gdalle commented Mar 5, 2025

Copy link
Copy Markdown
Member
  • Fix type-unstable compression to avoid getting a sparse matrix when the groups are empty
  • Add random ordering to benchmarks, otherwise bicoloring results are useless

@codecov

codecov Bot commented Mar 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (398490d) to head (32538cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #198   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1603      1611    +8     
=========================================
+ Hits          1603      1611    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 3d31ff0 into main Mar 5, 2025
Comment thread src/decompression.jl
@amontoison amontoison deleted the gd/typestab_compress branch March 5, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants