Skip to content

Create Invalidations.yml#259

Merged
kimikage merged 1 commit into
JuliaMath:masterfrom
ranocha:patch-1
Apr 13, 2024
Merged

Create Invalidations.yml#259
kimikage merged 1 commit into
JuliaMath:masterfrom
ranocha:patch-1

Conversation

@ranocha

@ranocha ranocha commented Sep 1, 2022

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Sep 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #259 (5192a57) into master (51b1838) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   93.08%   93.08%           
=======================================
  Files           6        6           
  Lines         767      767           
=======================================
  Hits          714      714           
  Misses         53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ranocha

ranocha commented Sep 28, 2022

Copy link
Copy Markdown
Member Author

Bump

@hyrodium hyrodium left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kimikage

kimikage commented Apr 6, 2024

Copy link
Copy Markdown
Collaborator

I don't see a problem with this per se, but I do have a question as to who this is for.
More precisely, the question is: Who will maintain the invalidation issues?

@ranocha

ranocha commented Apr 7, 2024

Copy link
Copy Markdown
Member Author

Whoever makes a PR increasing the number of invalidations has a chance to look at them?

@kimikage

kimikage commented Apr 7, 2024

Copy link
Copy Markdown
Collaborator

Since this package is relatively low-level, I think invalidation is a julia problem unless writing "too rude" code.
Unlike code coverage, it is not a rewarding index...

@kimikage

Copy link
Copy Markdown
Collaborator

The versions of several actions are outdated, but I will rely on dependabot.

@kimikage kimikage merged commit 6b0e6e1 into JuliaMath:master Apr 13, 2024
@kimikage

kimikage commented Apr 13, 2024

Copy link
Copy Markdown
Collaborator

Although this PR was merged under my responsibility, this workflow brought the very useful feature of ❌-marking new PRs. 🎉

More precisely, the question is: Who will maintain the invalidation issues?

cf. julia-actions/julia-invalidations#17

@kimikage

Copy link
Copy Markdown
Collaborator

workaround: #287

@kimikage kimikage mentioned this pull request Apr 30, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants