update package structure - #6
Merged
Merged
Conversation
shrinishLT
added a commit
to shrinishLT/smartui-cli
that referenced
this pull request
Sep 8, 2026
upload-pdf now accepts --config and reads thresholds from the same file exec uses, so one config.json serves web and PDF. Top-level approvalThreshold/rejectionThreshold apply to both; a new optional `pdf` block carries PDF-specific defaults and a per-file `thresholds` map keyed by resolved PDF name. Precedence for a PDF: CLI flag, then pdf block, then top-level config, then the project setting; the per-file map is taken whole from the first source that sets it. Strictly additive. `pdf` joins the schema's anyOf so a PDF-only file is valid for upload-pdf, and ctxInit keeps every other command on the old rule (web or mobile required) so exec behaves exactly as before. Unknown keys inside `pdf` are still rejected. Values are carried as strings via a helper that treats a numeric 0 as set, so an explicit 0 reaches the backend rather than being dropped. Verified against the built CLI: web-only, web+thresholds and web+pdf files authenticate on both commands; pdf-only authenticates on upload-pdf and is rejected by exec with the existing message; a typo inside pdf and an out-of-range value fail with the schema messages. The shared rejection<=approval check in ctxInit now also runs for PDF configs; that rule is under review separately (LambdaTest#6 on the RFC). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QbnKfTzhr64osinPevTmVG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.