app: grouped skills view with review-pipeline toggle - #26
Closed
alejandro-nexcade wants to merge 2 commits into
Closed
app: grouped skills view with review-pipeline toggle#26alejandro-nexcade wants to merge 2 commits into
alejandro-nexcade wants to merge 2 commits into
Conversation
Rebuild the Skills view (PR 2 of the overnight UX program) as a source-grouped master/detail. The left list groups skills by install source with mono uppercase headers and counts: a pinned REVIEW PIPELINE group, PERSONAL, one PLUGINS group per marketplace, PROJECT, and a COCKPIT STORE group that always shows (it carries the Install/sync affordances). A substring search filters across all groups. The detail pane shows the selected skill's name, path, source chip, description, and body via the shared <Markdown> renderer, plus a "Use in review" card wired to set_skill_review_pipeline. The SKILL.md editor is gated strictly on source.kind === "CockpitStore"; external sources (personal/plugin/project) are read-only with a managed note, so an external skill can never be copied into the store via save_skill. Grouping and search are pure helpers in lib/skill-groups.ts with unit tests covering group order, marketplace splitting, pipeline pinning, cross-group search, and empty-source handling. Store gains a setSkillReviewPipeline action (optimistic flip, reconciled with the refreshed list). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Selection uses border-primary (brand stays reserved for pipeline identity); review-pipeline toggles are disabled per-skill while a command is in flight so a stale response can't clobber the final click; handleSave re-asserts editability locally; failure rollback re-reads before surfacing the error so the message survives. Store tests pin all three behaviors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR 2/7 of the overnight UX program (Track B frontend —
cockpit-docs/OVERNIGHT_UX_PLAN.md). Stacked on #25.<Markdown>component with source chip + path.set_skill_review_pipeline, optimistic flip reconciled with the returned list; per-skill in-flight guard so a rapid double-toggle can't race; failure rolls back via re-read and still surfaces the error.CockpitStoreat the button, inhandleSave, and by the backend write path.border-primary(brand stays reserved for pipeline/agent identity), toggle race guard, save gate.Verified
tscclean ·vitest290 (16 new: 13 grouping/search helpers + 3 store toggle behaviors) ·vite buildok. Frontend-only diff; no Rust touched.🤖 Generated with Claude Code