ui-smoke: never sudo in crash capture#4146
Merged
Merged
Conversation
crashdump_arm ran `sudo sysctl` to set kernel.core_pattern, assuming passwordless sudo on CI. On a local run without it, sudo prompts for a password and stalls the whole suite until interrupted. Only adjust core_pattern (and apt-get gdb) when already root; non-root falls back to a cwd core. The tests now run unattended everywhere. Fixes LinuxCNC#4143
Contributor
Author
|
@BsAtHome Did you test? Good to merge? |
Contributor
|
Yes, tested and functional. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ui-smoke crash-capture helper (
crashdump_arm) ransudo sysctlto set
kernel.core_pattern, assuming passwordless sudo on CI. On alocal run without passwordless sudo, sudo prompts for a password on the
TTY and stalls the entire test suite until the user sends a keyboard
interrupt, as reported in #4143.
This drops sudo entirely: core_pattern is set (and gdb installed) only
when the suite already runs as root. Non-root runs skip it and fall
back to a cwd
core, so the tests run unattended on every host.Fixes #4143
Note: CI is expected to fail here for an unrelated reason. Debian sid
is currently broken, not this change.