refactor: generalize exchange detection#100
Merged
wpbonelli merged 6 commits intoJul 4, 2026
Merged
Conversation
Model/exchange name detection in ApiMbase._set_package_names, ApiMbase._create_package_list, and ApiSimulation.load hardcoded GWF-GWF/GWT-GWT prefix checks for identifying exchange packages. Replace with a general "X-X" pattern check (matching name minus its _<n> instance suffix) so GWE-GWE and any future same-domain exchange type is recognized without more hardcoded prefixes. Uses the existing get_package_type/package_factory machinery unchanged -- newly-detected exchange types still fall through to AdvancedPackage by default, same as GWF-GWF/GWT-GWT did before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check for "X-X" pattern to find like-model exchanges without hardcoding exchange names