Skip to content

Add Black Sea blockage#136

Merged
xylar merged 2 commits into
MPAS-Dev:masterfrom
xylar:add_black_sea_blockage
Apr 20, 2020
Merged

Add Black Sea blockage#136
xylar merged 2 commits into
MPAS-Dev:masterfrom
xylar:add_black_sea_blockage

Conversation

@xylar

@xylar xylar commented Apr 16, 2020

Copy link
Copy Markdown
Collaborator

This feature makes sure that the Black Sea is not included in MPAS meshes (as long as they use critical passages and critical land blockages, which high resolution meshes typically do not).

@xylar

xylar commented Apr 16, 2020

Copy link
Copy Markdown
Collaborator Author

@maltrud, @milenaveneziani, @jonbob and @mark-petersen, just take a look at this:
https://github.com/xylar/geometric_features/blob/add_black_sea_blockage/geometric_data/ocean/transect/Black_Sea_Blockage/transect.geojson
and let me know if you agree that this should be blocked off. Nothing else needed for your review for now.

@xylar xylar changed the title Add Black Sea Blockage Add Black Sea bockage Apr 16, 2020
@jonbob

jonbob commented Apr 16, 2020

Copy link
Copy Markdown

@xylar - does it also get rid of the Caspian?

@xylar

xylar commented Apr 16, 2020

Copy link
Copy Markdown
Collaborator Author

I don't see any way the Caspian Sea would ever connect to the open ocean. If it were through the Black Sea, then yes this would block it, too. Do you know of meshes where it wasn't culled?

@jonbob

jonbob commented Apr 16, 2020

Copy link
Copy Markdown

I think it's always been through the Black Sea, so this should take care of it. I just wasn't picturing it from the blockage transect

@jonbob jonbob left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from visual inspection

@mark-petersen mark-petersen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good. Thanks!

@xylar

xylar commented Apr 19, 2020

Copy link
Copy Markdown
Collaborator Author

@milenaveneziani and @maltrud, do you want to review this? It takes quite a bit of work to update geometric_features and compass so these changes make it into meshes, and I'd like to get started on that as soon as I can.

@xylar xylar requested a review from vanroekel April 19, 2020 08:50
@xylar

xylar commented Apr 19, 2020

Copy link
Copy Markdown
Collaborator Author

@vanroekel, would you also give it a look?

@vanroekel vanroekel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me. Approved via visual inspection

@xylar

xylar commented Apr 19, 2020

Copy link
Copy Markdown
Collaborator Author

I did a run with the mesh MPAS-Dev/MPAS-Model#518 using a compass environment with this version of geometric features. I verified that the Black Sea blockage is being included along with the 4 other blockages and that the mesh doesn't have the Black Sea (though this is not because of the blockage in this case).

xylar added 2 commits April 19, 2020 22:00
This feature makes sure that the Black Sea is not included in
MPAS meshes.
@xylar xylar force-pushed the add_black_sea_blockage branch from 3f9757e to 4be46cd Compare April 19, 2020 20:01
@xylar xylar removed the request for review from maltrud April 20, 2020 08:42
@xylar xylar changed the title Add Black Sea bockage Add Black Sea blockage Apr 20, 2020
@xylar xylar merged commit fd5a72f into MPAS-Dev:master Apr 20, 2020
@xylar xylar deleted the add_black_sea_blockage branch April 20, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants