Forward ScrollViewerAssist.BubbleVerticalScroll to nested ScrollViewers#4057
Merged
Conversation
Ensure `MouseWheel` and `Unloaded` event handlers are detached when `ScrollViewerAssist` functionality is removed from a `ScrollViewer`. This prevents potential memory leaks or incorrect behavior. Resolves MaterialDesignInXAML#4055
This reverts commit 2aa7e08.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4055
This forwards the attached property
materialDesign:ScrollViewerAssist.BubbleVerticalScrollto nestedScrollViewers in all of the controls mentioned in the issue.I added reproduction examples to the demo app homepage.
Warning
Please revert the following commit before merging:
docs: add reproduction to demo appOne additional issue I noticed: if the checkbox is enabled and then disabled again, scrolling still appears to be forwarded even though it should no longer be.
I suspect there may be an issue with unregistering in
OnBubbleVerticalScrollChanged.This only affects consumers that change the property at runtime, which is likely uncommon. I do not consider it a blocker for this PR, but it may be worth addressing in a follow-up PR.
In the examples below I am scrolling with my mouse wheel:
Before
ScrollViewerBubbleBefore.mp4
After
ScrollViewerBubbleAfter.mp4