*: upgrade postgres crates - #29157
Merged
Merged
Conversation
petrosagg
force-pushed
the
pg-dep-upgrade
branch
5 times, most recently
from
August 21, 2024 20:54
56bc699 to
6ac7000
Compare
petrosagg
changed the title
petrosagg
force-pushed
the
pg-dep-upgrade
branch
2 times, most recently
from
August 26, 2024 08:10
084d1b8 to
5033f23
Compare
petrosagg
force-pushed
the
pg-dep-upgrade
branch
3 times, most recently
from
September 3, 2024 13:42
ee3c7fb to
d2f27eb
Compare
petrosagg
commented
Sep 3, 2024
| .map(|f| { | ||
| Ok(( | ||
| f.type_(), | ||
| String::from_utf8_lossy(f.value_bytes()).into_owned(), |
Contributor
Author
There was a problem hiding this comment.
.value() is now deprecated so we do the string conversion on our side
| .unwrap() | ||
| .into_first(); | ||
| .into_iter() | ||
| .find(|m| matches!(m, SimpleQueryMessage::Row(_))) |
Contributor
Author
There was a problem hiding this comment.
Simple queries were changed and an additional message specifying the resulting schema is emitted first, so we must filter for the Row event instead of assuming it's the first one
petrosagg
marked this pull request as ready for review
September 3, 2024 13:44
petrosagg
force-pushed
the
pg-dep-upgrade
branch
from
September 3, 2024 13:49
d2f27eb to
da88c57
Compare
antiguru
approved these changes
Sep 3, 2024
petrosagg
force-pushed
the
pg-dep-upgrade
branch
from
September 3, 2024 14:10
da88c57 to
31afed2
Compare
jkosh44
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I tidied up our
rust-postgresfork and also brought in all changes from upstream. This PR brings in those changes. The highlight of those changes is that logical replication support is now a clean extension of the low levelCopyBothmechanism exposed by this upstream PR rust-postgres/rust-postgres#778Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.