Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
gantunesr
reviewed
Sep 15, 2026
ccharly
force-pushed
the
cc/feat/account-tree-remove-wallet
branch
from
September 16, 2026 14:24
b5edd0a to
118345d
Compare
ccharly
changed the base branch from
main
to
cc/fix/multichain-account-service-delete-accounts
September 16, 2026 14:25
ccharly
added this pull request to stack #10270
September 16, 2026 14:58
gantunesr
force-pushed
the
cc/feat/account-tree-remove-wallet
branch
from
September 17, 2026 15:24
30449ad to
2731bd7
Compare
Member
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Base automatically changed from
cc/fix/multichain-account-service-delete-accounts
to
main
September 17, 2026 18:32
ccharly
force-pushed
the
cc/feat/account-tree-remove-wallet
branch
from
September 17, 2026 18:32
2731bd7 to
4cab134
Compare
ccharly
marked this pull request as ready for review
September 17, 2026 18:38
Member
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
High Risk
This is a breaking account-management API that orchestrates wallet-wide deletion via keyring and multichain services, with best-effort behavior that can leave partially removed wallets and irreversible side effects on failure.
Overview
Adds a breaking
AccountTreeController:removeAccountWalletmessenger action so consumers can delete an entire account wallet and its accounts. The tree is not updated in place; removals go throughMultichainAccountService:removeMultichainAccountWallet(secondary entropy wallets) or per-accountKeyringController:removeAccount(hardware/Snap/keyring wallets), and pruning follows existingAccountsController:accountsRemovedhandling.Guardrails: requires initialization, rejects missing wallets, and blocks removal of the primary HD entropy wallet via new
EntropyRule.getPrimaryEntropySource(). Partial failures on non-entropy wallets are logged and reported through newreportRemoveAccountWalletError(console + optional Sentry), while continuing best-effort removal for other accounts.Integration: messenger allowlists and test mocks now register
AccountsController:getAccounts,KeyringController:removeAccount, andMultichainAccountService:removeMultichainAccountWallet. Changelog documents the breaking API and new dependencies.Reviewed by Cursor Bugbot for commit df6c659. Bugbot is set up for automated code reviews on this repo. Configure here.