Conversation
ccharly
force-pushed
the
cc/refactor/snap-account-cache
branch
from
September 17, 2026 21:29
de36aa6 to
d7dab0d
Compare
ccharly
force-pushed
the
cc/refactor/snap-account-cache
branch
from
September 17, 2026 21:32
d7dab0d to
3a46764
Compare
gantunesr
approved these changes
Sep 18, 2026
gantunesr
left a comment
gantunesr
left a comment
Member
There was a problem hiding this comment.
Just a couple of sonar errors, they can be resolved in the next PR
| import type { | ||
| AccountsControllerAccountsAddedEvent, | ||
| AccountsControllerAccountsRemovedEvent, | ||
| AccountsControllerGetStateAction, |
Member
There was a problem hiding this comment.
flagged by sonar: 'AccountsControllerGetStateAction' is defined but never used
| ): void { | ||
| rootMessenger.publish( | ||
| 'AccountsController:accountsRemoved', | ||
| accountIds as AccountsControllerAccountsRemovedEvent['payload'][0], |
Member
There was a problem hiding this comment.
Flagged by sonar: This assertion is unnecessary since it does not change the type of the expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist