Remove Arrow support#9
Merged
estebanzimanyi merged 1 commit intoJul 15, 2026
Merged
Conversation
MobilityDB removed the Arrow C Data Interface export (meos_arrow.h, meos_*_to_arrow / _from_arrow / _arrow_roundtrip). Drop it from the Go FFI: - codegen: remove meos_arrow.h from the header list and both cgo preambles, drop the -DARROW=1 build flag from the cgo CFLAGS, and remove the ArrowSchema/ArrowArray struct mapping; - regenerate: drop the meos_meos_arrow.go wrapper file, the meos_arrow.h #include from every generated cgo preamble, and the -DARROW=1 flag from the generated cgo directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the Arrow C Data Interface from the Go FFI, matching MobilityDB/MobilityDB#1389 which removes the Arrow export (
meos_arrow.h,meos_*_to_arrow/_from_arrow/_arrow_roundtrip).Generator (
tools/codegen.py):meos_arrow.hfrom the public-header list and from both cgo preambles;-DARROW=1build flag from the cgoCFLAGS;ArrowSchema/ArrowArraystruct mapping (dead once the arrow functions leave the catalog).Generated
functions/:meos_meos_arrow.gowrapper file;#include "meos_arrow.h"line from every cgo preamble and the-DARROW=1flag from the cgo directives.The regenerated surface is byte-identical to the committed files for the arrow-affected preambles, so this is exactly the arrow delta with no unrelated regeneration drift.