Store one SQL name per catalog function; drop the sqlfnAll/mdbCAll lists#51
Merged
Merged
Conversation
estebanzimanyi
changed the base branch from
feat/catalog-source-commit-stamp
to
master
Every catalog function entry now carries a single `sqlfn` (its primary SQL name) and `mdbC` (its primary wrapper). The `sqlfnAll`/`mdbCAll` lists — the extra SQL names and wrappers a shared wrapper or ever/always pair resolves to — are no longer written to the catalog: no binding generator reads them (every binding consumes only the singular `sqlfn`/`mdbC`), so they are dead surface that invites a lossy 1:1 read of a 1:N fan-out. `mdbCAll` had no reader at all, so it is simply dropped. `sqlfnAll` had one internal reader, the case-collision lint, which must still see every spelling (a straggler can appear only as a secondary name); `attach_sqlfn_map` now returns that fan-out as a transient map handed straight to `lint_sqlfn_case_collisions`, so collision coverage is unchanged while the names never reach the serialized catalog. The regenerated catalog differs from the previous output by exactly the `sqlfnAll`/`mdbCAll` keys and nothing else (all 4545 functions byte-identical otherwise); the lint still catches both primary and secondary-only collisions.
estebanzimanyi
force-pushed
the
feat/remove-sqlfnall-field
branch
from
3d33fc6 to
377a63e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each catalog function entry carries a single
sqlfn(primary SQL name) andmdbC(primary wrapper). The catalog omits thesqlfnAll/mdbCAlllists — the extra SQL names/wrappers one function resolves to when a shared wrapper or ever/always pair fans out.No binding generator reads those lists: every binding consumes only the singular
sqlfn/mdbC. They are dead surface that invites a lossy 1:1 read of a genuine 1:N fan-out (one MEOS primitive backing several external functions, per prefer-parameter).mdbCAllhas no reader, so it is dropped outright.sqlfnAllhas one internal reader, the case-collision lint, which needs every spelling.attach_sqlfn_mapreturns that fan-out as a transient map handed tolint_sqlfn_case_collisions, so collision coverage holds while the names stay out of the catalog.The regenerated catalog differs from the prior output by exactly the
sqlfnAll/mdbCAllkeys — all 4545 functions byte-identical otherwise — so every binding's output is unchanged. Stacked on #50.