Skip to content

add esp32/m5nanoh2 - #1676

Open
stc1988 wants to merge 2 commits into
Moddable-OpenSource:publicfrom
stc1988:device/nanoh2
Open

add esp32/m5nanoh2#1676
stc1988 wants to merge 2 commits into
Moddable-OpenSource:publicfrom
stc1988:device/nanoh2

Conversation

@stc1988

@stc1988 stc1988 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

I revised the setup implementation for the M5NanoC6 to match the M5NanoH2.

@phoddie

phoddie commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR. It generally looks fine.

There is one change that is unusual, the modification of esp32/manifest.json. This is the only time an M5 device has been added to this file. I acknowledge that the use of the esp32/manifest.json is a bit inconsistent.

If possible it would be best to keep support for individual boards in their own manifest rather than the overarching ESP-IDF manifest. Would you see if that is possible here? Thank you.

@stc1988

stc1988 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

I modified esp32/manifest.json because a build error occurred when including io/manifest.json on this board.
Since esp32h2 does not have Wi-Fi, it is necessary to avoid including manifest_net.json.
Currently, I cannot think of a way to handle this on the individual board side.

@phoddie

phoddie commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Ah, thanks. I understand now.

Maybe it is a mistake the ESP32 targets include manifest_net.json? Even for silicon with Wi-Fi, there are plenty of projects that don't use it and so don't need to carry it. That change will have a lot of ripple effects though...

@stc1988

stc1988 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Yes, I did feel it was a bit odd to include manifest_net.json, since it increases the build size for projects that do not use Wi-Fi.

I understand that developers are supposed to include manifest_net.json in projects that use Wi-Fi, so I think it would be fine to exclude it from the ESP32 targets. However, since the scope of impact is indeed large, I went ahead with this fix for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants