add esp32/m5nanoh2 - #1676
Conversation
|
Thanks for the PR. It generally looks fine. There is one change that is unusual, the modification of esp32/manifest.json. This is the only time an M5 device has been added to this file. I acknowledge that the use of the esp32/manifest.json is a bit inconsistent. If possible it would be best to keep support for individual boards in their own manifest rather than the overarching ESP-IDF manifest. Would you see if that is possible here? Thank you. |
|
I modified esp32/manifest.json because a build error occurred when including io/manifest.json on this board. |
|
Ah, thanks. I understand now. Maybe it is a mistake the ESP32 targets include |
|
Yes, I did feel it was a bit odd to include manifest_net.json, since it increases the build size for projects that do not use Wi-Fi. I understand that developers are supposed to include manifest_net.json in projects that use Wi-Fi, so I think it would be fine to exclude it from the ESP32 targets. However, since the scope of impact is indeed large, I went ahead with this fix for now. |
I revised the setup implementation for the M5NanoC6 to match the M5NanoH2.