Skip to content

fix(tui): add hardware cursor setting#1024

Draft
yuanzhi-code wants to merge 1 commit into
MoonshotAI:mainfrom
yuanzhi-code:codex/hardware-cursor-setting
Draft

fix(tui): add hardware cursor setting#1024
yuanzhi-code wants to merge 1 commit into
MoonshotAI:mainfrom
yuanzhi-code:codex/hardware-cursor-setting

Conversation

@yuanzhi-code

Copy link
Copy Markdown

Related Issue

Resolve #1022

Problem

See linked issue.

What changed

  • Added a terminal.show_hardware_cursor TUI preference and /settings selector for hardware cursor visibility.
  • Applied the setting during startup and /reload / /reload-tui so IME candidate windows can follow the input cursor on terminals that require a visible hardware cursor.
  • Updated the default tui.toml render path, migration stub detection, tests, docs, and changeset.

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue, or explained the problem above.
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

Verification:

  • corepack pnpm --config.engine-strict=false vitest run apps/kimi-code/test/tui/config.test.ts apps/kimi-code/test/tui/commands/reload.test.ts apps/kimi-code/test/tui/commands/update-preferences.test.ts apps/kimi-code/test/tui/components/dialogs/choice-picker.test.ts packages/migration-legacy/test/stub-detect.test.ts packages/migration-legacy/test/steps/config.test.ts
  • corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kimi-code run typecheck
  • corepack pnpm --config.engine-strict=false --filter @moonshot-ai/migration-legacy run typecheck
  • corepack pnpm --config.engine-strict=false exec oxlint apps/kimi-code/src/tui/commands/config.ts apps/kimi-code/src/tui/commands/reload.ts apps/kimi-code/src/tui/components/dialogs/hardware-cursor-selector.ts apps/kimi-code/src/tui/components/dialogs/settings-selector.ts apps/kimi-code/src/tui/components/index.ts apps/kimi-code/src/tui/config.ts apps/kimi-code/src/tui/kimi-tui.ts apps/kimi-code/src/tui/tui-state.ts apps/kimi-code/src/tui/types.ts packages/migration-legacy/src/stub-detect.ts
  • git diff --check

Note: Local verification used --config.engine-strict=false because this Windows environment has Node v22.19.0, below the repo requirement >=24.15.0.

@changeset-bot

changeset-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d8ee22d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@moonshot-ai/kimi-code Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(tui): IME candidate window can appear away from the prompt cursor

1 participant