fix(tui): add hardware cursor setting#1024
Draft
yuanzhi-code wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: d8ee22d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #1022
Problem
See linked issue.
What changed
terminal.show_hardware_cursorTUI preference and/settingsselector for hardware cursor visibility./reload//reload-tuiso IME candidate windows can follow the input cursor on terminals that require a visible hardware cursor.tui.tomlrender path, migration stub detection, tests, docs, and changeset.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Verification:
corepack pnpm --config.engine-strict=false vitest run apps/kimi-code/test/tui/config.test.ts apps/kimi-code/test/tui/commands/reload.test.ts apps/kimi-code/test/tui/commands/update-preferences.test.ts apps/kimi-code/test/tui/components/dialogs/choice-picker.test.ts packages/migration-legacy/test/stub-detect.test.ts packages/migration-legacy/test/steps/config.test.tscorepack pnpm --config.engine-strict=false --filter @moonshot-ai/kimi-code run typecheckcorepack pnpm --config.engine-strict=false --filter @moonshot-ai/migration-legacy run typecheckcorepack pnpm --config.engine-strict=false exec oxlint apps/kimi-code/src/tui/commands/config.ts apps/kimi-code/src/tui/commands/reload.ts apps/kimi-code/src/tui/components/dialogs/hardware-cursor-selector.ts apps/kimi-code/src/tui/components/dialogs/settings-selector.ts apps/kimi-code/src/tui/components/index.ts apps/kimi-code/src/tui/config.ts apps/kimi-code/src/tui/kimi-tui.ts apps/kimi-code/src/tui/tui-state.ts apps/kimi-code/src/tui/types.ts packages/migration-legacy/src/stub-detect.tsgit diff --checkNote: Local verification used
--config.engine-strict=falsebecause this Windows environment has Node v22.19.0, below the repo requirement>=24.15.0.