refactor(web): extract WorkspaceGroup from Sidebar#998
Merged
Conversation
🦋 Changeset detectedLatest commit: 880fc16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Merged
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A — internal refactor, no user-facing behavior change.
Problem
Sidebar.vuewas ~1098 lines, mixing the session column chrome (header, search, new-chat button), the workspace-group rendering (a repeated unit), and the floating workspace menus. The per-group rendering was the largest repeated block and made the file hard to navigate.What changed
Extract the workspace group rendering into a new
WorkspaceGroup.vuecomponent:Sidebar.vue1098 → 899 lines.WorkspaceGroup.vue(305 lines) renders one workspace group: header (folder icon, name / rename input, kebab⋯,+add), path line, session rows (SessionRow), show-more button, and empty state.WorkspaceGroupreceives the group data and parent state as props and forwards interactions up as emits (13 props, 12 emits). The floating menus (gh-menu,ws-menu), search, header, and new-chat button stay inSidebar.vue.WorkspaceGroup.vueso styling is identical; classes and DOM structure are byte-for-byte unchanged.No behavior change, no emit-signature change. Verified with
typecheck,test(26),build, andoxlint(0 errors / 0 warnings on the changed files).This is the first slice of the big-component split from the web refactor plan; further Sidebar extraction (menus) and the other large components (
ChatPane,ConversationPane,Composer) are follow-ups.Checklist
apps/kimi-web. Covered bytypecheck+ existing pure-logic tests.)gen-changesetsskill, or this PR needs no changeset. (Patch on@moonshot-ai/kimi-code;@moonshot-ai/kimi-webis ignored and bundled into the CLI.)gen-docsskill, or this PR needs no doc update. (No user-facing behavior change.)