Hi TN: Address, Electronic, Serial, and Cardinal FST Optimization and Bug Fix#461
Open
shrpawar-alt wants to merge 4 commits into
Open
Hi TN: Address, Electronic, Serial, and Cardinal FST Optimization and Bug Fix#461shrpawar-alt wants to merge 4 commits into
shrpawar-alt wants to merge 4 commits into
Conversation
… Bug Fixes Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
for more information, see https://pre-commit.ci
shrpawar-alt
marked this pull request as ready for review
July 24, 2026 17:13
mgrafu
reviewed
Jul 24, 2026
mgrafu
reviewed
Jul 24, 2026
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
for more information, see https://pre-commit.ci
mgrafu
reviewed
Jul 27, 2026
| electronic { protocol: "https" domain: "google.com/" } -> "https कोलन फॉरवर्ड स्लैश फॉरवर्ड स्लैश google डॉट com फॉरवर्ड स्लैश" | ||
| electronic { path: "C:\\Users\\HP\\Desktop" } -> "C कोलन बैकवर्ड स्लैश Users बैकवर्ड स्लैश HP बैकवर्ड स्लैश Desktop" | ||
| electronic { domain: "192.168.1.1" } -> "एक नौ दो डॉट एक छह आठ डॉट एक डॉट एक" | ||
| electronic { chem: "C₂H₄" } -> "सी दो एच चार" |
Collaborator
There was a problem hiding this comment.
let's make sure definition matches use and tag constraints
mgrafu
reviewed
Jul 27, 2026
| ) | ||
| # International grouping: 1-3 leading digits, one or more groups of 3. | ||
| western_grouping = pynini.closure(NEMO_ALL_DIGIT, 1, 3) + pynini.closure(delete_separator + three_digits, 1) | ||
| strip_separators = (indian_grouping | western_grouping).optimize() |
Collaborator
There was a problem hiding this comment.
what happens if we have mixed cases, like 1,23,456 vs 1,234,56?
mgrafu
reviewed
Jul 27, 2026
| """ | ||
| ordinal_graph = ordinal.graph | ||
| # Strip internal weights from ordinal graph so a small outer weight suffices | ||
| ordinal_graph = pynini.arcmap(ordinal.graph, map_type="rmweight").optimize() |
Collaborator
There was a problem hiding this comment.
does this change the behavior of ordinal?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.