feat(examples): add supervisor middleware content guard - #2169
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test 06c0433 |
|
/ok to test e8e6456 |
482309c to
6f57bfd
Compare
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
b03d1d7 to
bf8937e
Compare
drew
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Validation: This PR is project-valid because it adds a focused runnable example for the supervisor middleware roadmap tracked by #1733.
Head SHA: bf8937e60420fee61a22688495d13a2ea92f6f62
Review findings:
- Two warnings should be fixed before gator can move this PR to pipeline watch.
Docs: Example README is included; published Fern docs already cover the registration and policy fields used here, so no navigation change is required for this example-only addition.
Checks: Required branch checks, Helm Lint, Markdown, license, DCO, and Rust jobs are currently passing.
E2E: Deferred until review feedback is resolved.
Next state: gator:in-review
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
drew
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Validation: This PR is project-valid because it adds a focused runnable example for supervisor middleware work related to #1733.
Head SHA: e860e01192069af7f556e992999f8f266e4f3f1d
Thanks @pimlock, I checked your follow-up on the prior gator findings. The optional-field validation now rejects malformed mode and replacement values, and the smoke launcher now resolves the root and example Cargo target directories before launching binaries.
Review findings:
- One warning remains on redaction behavior for overlapping configured terms.
Docs: Example README is included; this is example-local UX documentation, so I do not see a Fern docs or navigation update requirement for this PR.
Checks: DCO, Markdown, License Headers, Helm Lint, and several branch-check jobs are passing; OpenShell / Branch Checks and Rust jobs are still pending on the current head.
E2E: test:e2e is not applied yet. E2E should be decided after review feedback is resolved.
Next state: gator:in-review
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
drew
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Validation: This PR is project-valid because it adds a focused runnable example for supervisor middleware work related to #1733.
Head SHA: 2f5751a706e894853ebe5bd46b2fe4f8adc1f2d6
Thanks @pimlock, I checked the latest update. The optional-field validation and target-directory handling remain resolved, and the new longest-first ordering fixes the prefix-overlap case from the prior review.
Review findings:
- One warning remains on redaction behavior for partially overlapping configured terms.
Docs: Example README is included; this is example-local UX documentation, so I do not see a Fern docs or navigation update requirement for this PR.
Checks: DCO, Markdown, License Headers, Helm Lint, Branch Checks, Rust, Python, and mise Lockfile are passing on the current head.
E2E: test:e2e is not applied yet. E2E should be decided after review feedback is resolved.
Next state: gator:in-review
drew
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Validation: This PR is project-valid because it adds a focused runnable example for supervisor middleware work related to #1733.
Head SHA: 9ca89d99c3ca7bb7fcecebd2f79b9584505f521f
Thanks @pimlock, I checked the README warning-alert update in this head. The docs markup change is fine, but the redaction behavior issue from the prior head is still present because the Rust code did not change.
Review findings:
- One warning remains on redaction behavior for partially overlapping configured terms.
Docs: Example README is included; this is example-local UX documentation, so I do not see a Fern docs or navigation update requirement for this PR.
Checks: CI has restarted for this head; DCO is passing, and Branch Checks, Helm Lint, Rust, Python, Markdown, License Headers, and mise Lockfile are pending.
E2E: test:e2e is not applied yet. E2E should be decided after review feedback is resolved.
Next state: gator:in-review
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
drew
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Validation: This PR is project-valid because it adds a focused runnable example for supervisor middleware work related to #1733.
Head SHA: 0623b7030ff867e775b345915039e990af2c9b23
Thanks @pimlock, I checked your latest follow-up on the overlapping redaction findings. The current implementation computes matches from the original UTF-8 body, merges overlapping ranges, rebuilds the redacted body once, and includes partial/self-overlap regression coverage.
Review findings:
- No blocking findings remain.
Docs: Example README is included; this is example-local UX documentation, so I do not see a Fern docs or docs/index.yml navigation update requirement.
Checks: Required Branch Checks, Helm Lint, DCO, Markdown, License Headers, Rust, Python, and mise Lockfile are passing on the current head.
E2E: test:e2e is required for this supervisor middleware/network-policy smoke example and is being applied for pipeline monitoring.
Next state: gator:watch-pipeline
|
Label |
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: The last gator state was I removed the active |
Summary
Add a runnable supervisor middleware content-guard example for the middleware shipped in #2027. The example demonstrates operator-run service registration, policy attachment, request-body inspection, and allow, deny, and redact responses.
Related Issue
Related to #1733
Changes
network_middlewaresformat and operator-owned registration namesmoke.shto build and launch the gateway, middleware, and sandbox with automatic cleanuphttpbin.orgrequest and an unguardedhttpbingo.orgrequestopenshell.supervisor.middlewareregistration, body limit, and timeout behaviorTesting
mise run pre-commitpassesexamples/supervisor-middleware-content-guard/smoke.sh --test-suitepassescargo test --manifest-path examples/supervisor-middleware-content-guard/Cargo.tomlpassesChecklist