Skip to content

CI: Require all checks passing before merging #377

Description

@leofang

It has come to my attention that we can have PRs merged without all CI pipelines passing. Since 1. we have working CIs now, and 2. we've fixed the flaky build failures (#271), I ask that we enforce the CI checks being run & green before any PR gets merged.

Unfortunately, the GitHub built-in "required status check" is pretty crappy and useless (https://github.com/orgs/community/discussions/13690). We'll need an alternative. I see that our org admin has approved the usage of this action: https://github.com/poseidon/wait-for-status-checks. I suggest that we give it a shot.

cc @NVIDIA/cuda-python-dev for vis

Metadata

Metadata

Assignees

No one assigned

    Labels

    CI/CDCI/CD infrastructureP0High priority - Must do!

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions