-
Notifications
You must be signed in to change notification settings - Fork 334
ci: clean up recurring nightly optional-deps failures #2968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f2e8d37
ci: pin numpy<2.5 for nightly-numba-cuda and add cccl for numba-cuda-…
leofang 4363950
TEMP: add push trigger to ci-nightly.yml to verify fix on this PR
leofang feb41f7
ci: deselect frozen-driver-table test on released cuda-core <=1.2.1
leofang f106b1f
ci: skip numba-cuda IPC tests and mlir test_device_record_copy
leofang f0682bf
ci: move pytest<9 pin for numba-cuda into ci/tools/run-tests
leofang 31f7af7
ci: downgrade pytest to <9 as a second pip call for numba-cuda
leofang 13a2035
ci: use --import-mode=importlib for numba-cuda pytest run
leofang 3bc4acc
ci: run numba-cuda tests from checked-out source, mirroring mlir
leofang b53d482
ci: swap --ignore-glob for -k 'not TestIpc' in numba-cuda pytest
leofang 4866459
Revert "TEMP: add push trigger to ci-nightly.yml to verify fix on thi…
leofang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -467,9 +467,32 @@ jobs: | |
| pytest -rxXs -v tests/test_utils.py tests/example_tests/ | ||
| popd | ||
|
|
||
| - name: Checkout numba-cuda tests at matching tag | ||
| if: ${{ inputs.test-mode == 'nightly-numba-cuda' && env.NUMBA_CUDA_VER != '' }} | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| repository: NVIDIA/numba-cuda | ||
| ref: v${{ env.NUMBA_CUDA_VER }} | ||
| path: numba-cuda-released | ||
|
|
||
| - name: Run numba-cuda tests | ||
| if: ${{ inputs.test-mode == 'nightly-numba-cuda' }} | ||
| run: python -m numba.runtests numba.cuda.tests | ||
| if: ${{ inputs.test-mode == 'nightly-numba-cuda' && env.NUMBA_CUDA_VER != '' }} | ||
| env: | ||
| LOCAL_CTK: ${{ matrix.LOCAL_CTK }} | ||
| run: | | ||
| if [[ "${LOCAL_CTK}" != 1 ]]; then | ||
| # Let numba-cuda skip inputs that require toolkit executables. | ||
| export NUMBA_CUDA_TEST_WHEEL_ONLY=1 | ||
| fi | ||
| # Run from numba-cuda's testing/ dir so its pytest.ini kicks in | ||
| # (consider_namespace_packages=true + --pyargs numba.cuda.tests). | ||
| # -k "not TestIpc": numba-cuda v0.30.4 accesses CUipcMemHandle.reserved, | ||
| # which cuda-bindings intentionally removed. numba-cuda is EOL upstream, | ||
| # so no fix is coming. See cuda-python#2748. The affected tests all | ||
| # live in the two TestIpcMemory/TestIpcStaged classes in test_ipc.py. | ||
| pushd numba-cuda-released/testing | ||
| pytest -v -k "not TestIpc" | ||
| popd | ||
|
|
||
| - name: Checkout numba-cuda-mlir tests at matching tag | ||
| if: ${{ inputs.test-mode == 'nightly-numba-cuda-mlir' && env.NUMBA_CUDA_MLIR_VER != '' }} | ||
|
|
@@ -495,9 +518,13 @@ jobs: | |
| # Skip tests/benchmarks/ and tests/doc_examples/ — they import the | ||
| # numba package at collection time, which cuSIMT intentionally does | ||
| # not depend on. See NVIDIA/numba-cuda-mlir#136. | ||
| # test_device_record_copy (WithRecord variant): flaky NaN vs NaN | ||
| # compare from uninitialized np.recarray memory. See | ||
| # NVIDIA/numba-cuda-mlir#341. | ||
| pytest -rxXs -v \ | ||
| --ignore=tests/benchmarks \ | ||
| --ignore=tests/doc_examples \ | ||
| --deselect 'tests/numba_cuda_tests/cudadrv/test_cuda_devicerecord.py::TestCudaDeviceRecordWithRecord::test_device_record_copy' \ | ||
| tests/ | ||
| popd | ||
|
|
||
|
|
@@ -520,8 +547,8 @@ jobs: | |
| # patterns that pytest 9.1 rejects; the main-side fix (#2212) has | ||
| # not yet shipped in a cuda-core release. | ||
| pip install "pytest<9.1" | ||
| # Version-gated deselect: drops automatically when a newer | ||
| # cuda-core release with the wrapper-mapping update ships. | ||
| # Version-gated deselects: drop automatically when a newer | ||
| # cuda-core release ships that removes each source. | ||
| DESELECTS=() | ||
| if python -c "from packaging.version import Version; import sys; sys.exit(0 if Version('${CUDA_CORE_RELEASED_VER}') <= Version('1.0.1') else 1)"; then | ||
| # NvlinkVersion: v1.0.1's wrapper mapping predates | ||
|
|
@@ -531,6 +558,15 @@ jobs: | |
| --deselect 'tests/test_enum_coverage.py::test_wrapper_covers_all_binding_members[NvlinkVersion]' | ||
| ) | ||
| fi | ||
| if python -c "from packaging.version import Version; import sys; sys.exit(0 if Version('${CUDA_CORE_RELEASED_VER}') <= Version('1.2.1') else 1)"; then | ||
| # test_frozen_driver_table_covers_all_curesult_members: v1.2.1's | ||
| # frozen table (capped at CTK 13.1.1) predates 3 CUresult members | ||
| # added by main cuda-bindings 13.4.1. Reverted on main by #2792; | ||
| # drop this deselect once a cuda-core release with the revert ships. | ||
| DESELECTS+=( | ||
| --deselect 'tests/test_utils_enum_explanations_helpers.py::test_frozen_driver_table_covers_all_curesult_members' | ||
| ) | ||
| fi | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately #2792 did not catch any cuda.core v1.2.x release and only lives on the main branch, so we have to fix the nightly CI this way. |
||
| pytest -rxXs -v --randomly-dont-reorganize \ | ||
| "${DESELECTS[@]}" \ | ||
| tests/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.