fix: update digest lookup to use versioned RepoTags instead of latest#1935
fix: update digest lookup to use versioned RepoTags instead of latest#1935shivakunv wants to merge 1 commit into
Conversation
deb4294 to
e789ee7
Compare
|
PTAL @cdesiniotis @tariq1890 |
a8eb42b to
6f8277b
Compare
rajathagasthya
left a comment
There was a problem hiding this comment.
This largely looks good to me. Just a couple of questions.
6f8277b to
f3e6ed9
Compare
|
PTAL @tariq1890 Regarding this section: I have only added TODO comments. |
|
@shivakunv I took a look at some of the sample PRs raised in your fork, and I noticed that only one line gets updated in the |
6e19949 to
c769a2d
Compare
@cdesiniotis Thanks!! Please check my repo PRs opened by renovate: |
I see two PRs raised today, https://github.com/shivakunv/gpu-operator-shiva/pull/233 and https://github.com/shivakunv/gpu-operator-shiva/pull/232. Both of these PRs only update the helm values, and not the CSV file. |
@cdesiniotis Please check the snippets below for PR: https://github.com/shivakunv/gpu-operator-shiva/pull/220
|
c769a2d to
eaa6081
Compare
|
Other than few minor comments, the PR looks good to me. |
2061238 to
0c22e75
Compare
0c22e75 to
b875ade
Compare
4c50f01 to
a63305b
Compare
2587090 to
f137ff6
Compare
f137ff6 to
2f55809
Compare
304d31a to
e38fef9
Compare
70b2ac7 to
fc3c9b6
Compare
Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
fc3c9b6 to
8d1300c
Compare

Biggest risk in config:
1, values.yaml and CSV are managed independently, so renovate can update one without keeping the other in sync.
2. Same tag, new digest, If the tag still exists, but upstream re-pushes that same tag to a different image, Renovate may keep the tag the same and only change the digest in csv file
Current Issue:
Renovate always pulls the digest from the latest tag, which results in a SHA difference.
However, the version in the
values.yamlfile is not updated in this scenario, so the digest in the manifests becomes mismatched and stale.Solution:
Open a PR only when the RepoTags value in values.yaml changes.
Then search for that exact digest in
bundle/manifests/gpu-operator-certified.clusterserviceversion.yamlinstead of using the digest from latest.
check open PRs:
https://github.com/shivakunv/gpu-operator/pulls