jpackage adjustments for windows and linux - #112
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Windows and Linux jpackage release packaging flow by centralizing common “app + additional launchers” arguments into a shared argfile and wiring optional --runtime-image support into the native-installer step.
Changes:
- Remove
--app-image/--namefrom the Windows/Linux platform-specificjpackageconfig files and provide them via a shared launcher argfile instead. - Add
jpackage/jpackage-app-launchers.cfgto supply--input,--main-jar,--main-class,--name, and--add-launcherflags for installer builds. - Pass
--runtime-image(when provided) to the Windows/Linux native-installerjpackageinvocation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| jpackage/jpackage-windows.cfg | Makes Windows config platform-specific only (no longer sets --app-image / --name). |
| jpackage/jpackage-linux.cfg | Makes Linux config platform-specific only and keeps --linux-shortcut behavior. |
| jpackage/jpackage-app-launchers.cfg | New shared argfile providing main app/launcher configuration for installer builds. |
| build-windows-release.sh | Includes the new shared argfile in the installer step and propagates optional --runtime-image. |
| build-linux-release.sh | Includes the new shared argfile in the installer step and propagates optional --runtime-image. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
NateIsStalling
requested a deployment
to
Production
August 12, 2026 20:16 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
NateIsStalling
had a problem deploying
to
Production
August 12, 2026 20:34 — with
GitHub Actions
Failure
GitHub Actions
Failure
NateIsStalling
had a problem deploying
to
Production
August 13, 2026 04:07 — with
GitHub Actions
Failure
GitHub Actions
Failure
NateIsStalling
had a problem deploying
to
Production
August 13, 2026 05:17 — with
GitHub Actions
Failure
GitHub Actions
Failure
This reverts commit 6fdc9fd.
NateIsStalling
had a problem deploying
to
Production
August 13, 2026 14:05 — with
GitHub Actions
Failure
GitHub Actions
Failure
NateIsStalling
had a problem deploying
to
Production
August 13, 2026 18:47 — with
GitHub Actions
Failure
GitHub Actions
Failure
NateIsStalling
had a problem deploying
to
Production
August 13, 2026 19:28 — with
GitHub Actions
Failure
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.