Fix Pint code style, add CI Pint check, and remove unused welcome view - #4
Open
prateekbhujel wants to merge 1 commit into
Open
prateekbhujel wants to merge 1 commit into
prateekbhujel wants to merge 1 commit into
Conversation
Fix code style violations identified by Pint across providers and native components, enforce Pint checks in the GitHub Actions workflow, and delete the unused 72KB welcome.blade.php leftover from framework scaffolding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.mdspecifies:This PR cleans up code style across the starter kit, enforces style compliance in CI, and removes unused scaffold boilerplate.
Changes
NativeServiceProvider.php,Home.php, andAppInfoTool.php(ordered imports, strict types, blank lines, trailing newline).vendor/bin/pint --teststep to.github/workflows/tests.yml.resources/views/welcome.blade.phpleftover fromlaravel new(root/routes directly toHome::classrenderingnative.home).