fix: stabilize PR comment sessions#58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simdeck daemon run.SIMDECK_DAEMON_METADATA_PID, so PR-session lifecycle checks watch the right PID.Root cause
The PR-comment workflows install SimDeck from npm, where
simdeckisbin/simdeck.mjs. The native daemon already exits with code75for recoverable restarts, but the npm wrapper passed that exit through. The workflow then treated the wrapper PID as dead even though daemon metadata could still point at a separate native process.Testing
npm run test:github-actionsnpx prettier --check bin/simdeck.mjs actions/run-ios-comment-session/action.yml actions/run-android-comment-session/action.yml scripts/github-actions.test.mjsgit diff --check