feat: add router input binding#165
Open
edusperoni wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for Angular-style “bind route params/data to component inputs” when navigating through NativeScript’s PageRouterOutlet, plus a demo screen and unit tests in the demo app.
Changes:
- Introduces
RoutedComponentInputBinderand wiring inPageRouterOutletto push mergedqueryParams/params/datainto component inputs viaComponentRef.setInput. - Adds router-module helpers to register the binder (standalone provider + opt-in via router config / feature detection).
- Adds demo route/UI and a Jasmine spec suite covering binding behavior and edge cases.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/angular/src/lib/legacy/router/router.module.ts | Adds binder provider registration helpers and attempts to auto-enable when Angular component-input-binding feature is present. |
| packages/angular/src/lib/legacy/router/router-component-input-binder.ts | New binder service that subscribes to route observables and sets component inputs based on merged route state. |
| packages/angular/src/lib/legacy/router/page-router-outlet.ts | Integrates the binder into outlet lifecycle (bind on activation, unsubscribe on detach/deactivate/destroy). |
| apps/nativescript-demo-ng/src/tests/router-component-input-binder.spec.ts | New unit tests validating binding precedence, query param opt-out, unmatched input behavior, and resubscription/unsubscribe logic. |
| apps/nativescript-demo-ng/src/main.ts | Enables the feature in the demo app via withComponentInputBinding(). |
| apps/nativescript-demo-ng/src/app/item3/items.component.html | Adds navigation button to the new input-binding demo route. |
| apps/nativescript-demo-ng/src/app/input-binding-demo/input-binding-demo.component.ts | New demo component displaying bound param/query/data/resolver values (signal inputs). |
| apps/nativescript-demo-ng/src/app/app.routes.ts | Adds a demo route with param, static data, and resolver data. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… for consistency and don't use magic numbers
Comment on lines
+46
to
+47
| const COMPONENT_INPUT_BINDING_FEATURE_KIND = (angularWithComponentInputBinding() as any).ɵkind; | ||
|
|
Comment on lines
+48
to
+54
| function inputBinderProviders(options: ComponentInputBindingOptions = {}): Provider[] { | ||
| return [{ provide: INPUT_BINDER, useFactory: () => new RoutedComponentInputBinder(options) }]; | ||
| } | ||
|
|
||
| export function provideComponentInputBinding(options: ComponentInputBindingOptions = {}): Provider[] { | ||
| return inputBinderProviders(options); | ||
| } |
| private outletSeenKeys = new Map<PageRouterOutlet, Set<string>>(); | ||
|
|
||
| constructor(private options: ComponentInputBindingOptions) { | ||
| this.options.queryParams ??= true; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
This adds support to angular component input binding