feat: use upstream angular router link#166
Open
edusperoni wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aligns NativeScript’s legacy nsRouterLink / nsRouterLinkActive directives more closely with upstream Angular Router behavior to address issue #145 where nsRouterLinkActive wasn’t applying active classes.
Changes:
- Reworks
NSRouterLinkto use Angular DI (inject) + signals/computed state and to supportUrlTreeinputs. - Reimplements
NSRouterLinkActiveactive-checking using Angular Router’s active-match options (and addsaria-current+isActiveChangesupport). - Removes the locally-copied private URL tree helpers and updates router-link tests to use Angular
TestBed.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/angular/src/lib/legacy/router/private-imports/router-url-tree.ts | Removes copied Angular Router private helper implementation. |
| packages/angular/src/lib/legacy/router/ns-router-link.ts | Refactors NSRouterLink to upstream-like inputs/state handling and adds UrlTree support. |
| packages/angular/src/lib/legacy/router/ns-router-link-active.ts | Updates active-link detection logic and adds aria-current/isActiveChange behavior. |
| apps/nativescript-demo-ng/src/tests/ns-router-link.spec.ts | Migrates tests to TestBed and validates navigation extras/transition behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145