Do not symlink build-tools directory#1694
Merged
Merged
Conversation
Due to latest changes in Android runtime, we can no longer symlink `build-tools` directory from the runtime when `--symlink` is passed. There are two major reasons: - There are `.js` files in the build-tools, which use `require(<smth>)`. This is failing as node's searching for the installed modules from the original location of the file. - During build, new files are generated in the build-tools directory. As they are unique (each one is project specific), we cannot symlink them.
Contributor
|
👍 |
1 similar comment
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to latest changes in Android runtime, we can no longer symlink
build-toolsdirectory from the runtime when--symlinkis passed.There are two major reasons:
.jsfiles in the build-tools, which userequire(<smth>). This is failing as node's searching for the installed modules from the original location of the file.