Skip to content

Add interpolation for app.gradle applicationId value in android projects#1873

Merged
petekanev merged 1 commit into
masterfrom
pete/appGradle-add-applicationId
Jun 23, 2016
Merged

Add interpolation for app.gradle applicationId value in android projects#1873
petekanev merged 1 commit into
masterfrom
pete/appGradle-add-applicationId

Conversation

@petekanev

Copy link
Copy Markdown
Contributor

Change applicationId field in app.gradle for android projects
Need to add a Grade Android.defaultConfig #454

ping: @rosen-vladimirov @enchev @Plamen5kov

@petekanev
petekanev force-pushed the pete/appGradle-add-applicationId branch from 2c55e62 to 33c87b5 Compare June 23, 2016 05:48
@enchev

enchev commented Jun 23, 2016

Copy link
Copy Markdown
Contributor

👍

@petekanev
petekanev merged commit 4c19c4a into master Jun 23, 2016
@petekanev
petekanev deleted the pete/appGradle-add-applicationId branch June 23, 2016 10:55
@ghost

ghost commented Jan 3, 2018

Copy link
Copy Markdown

@Pip3r4o There's a big problem with this; it interpolates in the App_Resources folder instead of the platform folder so it's not reusable..

@petekanev

Copy link
Copy Markdown
Contributor Author

@vbresults one might call that a problem, another - a feature and intended behavior.

If you believe this to be a problem, please open an issue, stating why you think so, and how you think it should be implemented instead.

As of the current NativeScript version, the app.gradle is interpolated inside the App_Resources, and will not be copied over to platforms/android for additional transformations and interpolations. The file is left entirely in the application author's control beyond the initial interpolation to set a default value for the package name. The team is working on additional features and ways to change that value using json config file. pinging @KristianDD as he might be able to share more about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants