Fix options validation for 'tns prepare', add validation for 'tns livesync', fix .name to .uuid in provision checks#2405
Merged
Conversation
| this.$errors.fail("When producing a release build, you need to specify all --key-store-* options."); | ||
| } | ||
| return args.length === 0 && this.$platformService.validateOptions(this.$platformsData.availablePlatforms.Android).wait(); | ||
| return this.$platformService.validateOptions(this.$platformsData.availablePlatforms.Android).wait(); |
Contributor
There was a problem hiding this comment.
In case user writes tns run android some other arguments the command will still be executed, which is change from the current behavior. Is this intended?
Contributor
Author
There was a problem hiding this comment.
Yes, the zero check was an error. Whatever the options, once tns run android ... is called, the platformService should validate for android options.
PanayotCankov
force-pushed
the
cankov/fix-options-validation
branch
from
January 11, 2017 12:11
2b20676 to
6b8bf02
Compare
…esync', fix .name to .uuid in provision checks
PanayotCankov
force-pushed
the
cankov/fix-options-validation
branch
from
January 11, 2017 13:58
6b8bf02 to
6e1bc58
Compare
rosen-vladimirov
approved these changes
Jan 11, 2017
rosen-vladimirov
left a comment
rosen-vladimirov
left a comment
Contributor
There was a problem hiding this comment.
After green build
|
run ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.