Update ws module version#3488
Merged
Merged
Conversation
In order to fix vulnerabilities problems we need to update the version of ws module - https://nodesecurity.io/check/nativescript
rosen-vladimirov
approved these changes
Mar 26, 2018
rosen-vladimirov
left a comment
rosen-vladimirov
left a comment
Contributor
There was a problem hiding this comment.
After fixing comment. Great work!
| ], | ||
| "dependencies": { | ||
| "@types/ora": "1.3.2", | ||
| "@types/ws": "4.0.1", |
Contributor
There was a problem hiding this comment.
this should be devDependency: npm i --save-dev --save-exact @types/ws
Contributor
There was a problem hiding this comment.
btw the @types/ora need to be devDependency as well
Update common lib
Contributor
Author
|
run ci |
2 similar comments
Contributor
Author
|
run ci |
Contributor
Author
|
run ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to fix vulnerabilities problems we need to update the version of ws module - https://nodesecurity.io/check/nativescript