Skip to content

Fix project creation#3615

Merged
Fatme merged 1 commit into
masterfrom
fatme/fix-project-creation
May 25, 2018
Merged

Fix project creation#3615
Fatme merged 1 commit into
masterfrom
fatme/fix-project-creation

Conversation

@Fatme

@Fatme Fatme commented May 25, 2018

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

tns create template-tab-navigation-ng --template https://github.com/NativeScript/template-tab-navigation-ng#master does not work

What is the new behavior?

tns create template-tab-navigation-ng --template https://github.com/NativeScript/template-tab-navigation-ng#master works as expected

@rosen-vladimirov rosen-vladimirov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note the problem is with npm 5.6.0.
The current workflow is:

  1. Create project dir and package.json
  2. Install the template as dependency of the project
  3. Move the files from the template to the project dir (or its app directory)
  4. Call npm install tns-core-modules --save in case the template does not have dependency for tns-core-modules.
  5. Read the package.json of the template installed in node_modules
  6. Call npm install at the root of the project

However, npm decides to uninstall the template on step 4. Not sure why...
At step 6, when we call npm install the template is again installed in node_modules, so we can read its package.json

@rosen-vladimirov

Copy link
Copy Markdown
Contributor

run ci

@Fatme
Fatme merged commit 4c259e4 into master May 25, 2018
@Fatme
Fatme deleted the fatme/fix-project-creation branch May 25, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants