Skip to content

Make appResourcesChanged check to be executed per platform#3619

Merged
Fatme merged 1 commit into
releasefrom
fatme/fix-app-resources-changed
Jun 1, 2018
Merged

Make appResourcesChanged check to be executed per platform#3619
Fatme merged 1 commit into
releasefrom
fatme/fix-app-resources-changed

Conversation

@Fatme

@Fatme Fatme commented May 25, 2018

Copy link
Copy Markdown
Contributor

In case when when something is changed in app/App_Resources/iOS folder, tns run android command executes full application build. Actually there is no need to rebuild the application in this case. Make the appResourcesDirectoryChanged to be checked per platform so no rebuild is triggered.

PR Checklist

@Fatme Fatme added this to the 4.1.0 milestone May 25, 2018
@Fatme
Fatme changed the base branch from master to release May 25, 2018 22:06
@Fatme
Fatme force-pushed the fatme/fix-app-resources-changed branch from 25fe264 to d04fe89 Compare May 25, 2018 22:10
@Fatme

Fatme commented May 26, 2018

Copy link
Copy Markdown
Contributor Author

run ci

@rosen-vladimirov rosen-vladimirov modified the milestones: 4.1.0, 4.1.1 May 28, 2018
@Fatme
Fatme merged commit dfd687b into release Jun 1, 2018
@Fatme
Fatme deleted the fatme/fix-app-resources-changed branch June 1, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants