Fix assets generation#3638
Merged
Merged
Conversation
rosen-vladimirov
self-requested a review
May 29, 2018 14:02
Contributor
|
run ci |
rosen-vladimirov
suggested changes
Jun 1, 2018
rosen-vladimirov
left a comment
rosen-vladimirov
left a comment
Contributor
There was a problem hiding this comment.
Please retarget this fix to release branch, so we can include it in 4.1.1 release
When we don't find asset in the default image definitions(image-definitions.json) we skip width and height parsing. Then the image generation fails. Now we set the correct size even we don't find default asset properties. ProgressNS/sidekick-feedback#199
ivanovit
force-pushed
the
IIIvanov/fix-assets-generation-2
branch
from
June 1, 2018 10:10
0894a2f to
91f998c
Compare
Contributor
Author
|
ping @rosen-vladimirov |
rosen-vladimirov
approved these changes
Jun 1, 2018
rosen-vladimirov
left a comment
rosen-vladimirov
left a comment
Contributor
There was a problem hiding this comment.
After green build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
When we don't find an asset in the default image definitions(image-definitions.json) we skip width and height parsing. Then the image generation fails because width and height are undefined.
What is the new behavior?
Now we set the correct size even we don't find default asset properties.
Fixes ProgressNS/sidekick-feedback#199.
PR Checklist