fix: native frameworks/code is added to tns_modules dir#3924
Merged
Conversation
The `<project dir>/platforms/<platform>/.../tns_modules` directory should contain only the `.js` code of the application. However, in case nativescript plugin is installed in the `node_modules` directory of another package (not directly inside the project), its platforms directory is copied to `tns_modules` as well. This leads to error when trying to build application that has such structure with Xcode 10. After copying the `node_modules` to `tns_modules` recursively remove all `platforms` directories of all nativescript plugins inside node_modules.
DimitarTachev
approved these changes
Sep 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
<project dir>/platforms/<platform>/.../tns_modulesdirectory should contain only the.jscode of the application. However, in case nativescript plugin is installed in thenode_modulesdirectory of another package (not directly inside the project), its platforms directory is copied totns_modulesas well. This leads to error when trying to build application that has such structure with Xcode 10.After copying the
node_modulestotns_modulesrecursively remove allplatformsdirectories of all nativescript plugins inside node_modules.PR Checklist
What is the current behavior?
Build with Xcode fails when nativescript plugin is installed as dependency in node_modules (i.e. it is not installed directly in the node_modules dir of the project.
What is the new behavior?
Build succeeds
Fixes #3932