Skip to content

fix: do not use HMR when debugBrk is set as we will restart the app on each LiveSync #4600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DimitarTachev merged 1 commit into from
May 8, 2019
Merged

fix: do not use HMR when debugBrk is set as we will restart the app on each LiveSync #4600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ export class Options {
this.argv.bundle = undefined;
this.argv.hmr = false;
}

if (this.argv.debugBrk) {
// we cannot use HMR along with debug-brk because we have to restart the app
// on each livesync in order to stop and allow debugging on app start
this.argv.hmr = false;
}
}

constructor(private $errors: IErrors,
Expand Down