Refactor project and platform services#7
Merged
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
action shouldn't be any. Rather, it should be, let's say, action: (...args: any[]) => void.
Contributor
There was a problem hiding this comment.
you can simplify the signature for args by using open-ended arguments: ...args: any[]
Contributor
Author
There was a problem hiding this comment.
Agree :) It looks better
Contributor
Author
Contributor
There was a problem hiding this comment.
This is odd. Isn't options.release a boolean value? Why would it have the value --release ?
Contributor
There was a problem hiding this comment.
This method can be made private in the implementation. The installSafe method can be renamed to just install, then.
Contributor
Author
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need this refactoring in order to reuse code for
iOSProjectService