fix(ontap): handle missing SnapMirror policy field#44
Open
navyaa14 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #33.
list_snap_mirror_relationships()accessedrelationship.policy.typeunconditionally. When aSnapmirrorRelationshipSDK object does not expose the optionalpolicyfield, the SDK raises anAttributeError, preventing the available relationship data from being returned.Fix
Safely return
NoneforTypewhenpolicy.typeis unavailable, while preserving the existing value when the field is present.I intentionally left
get_collection()unchanged because the function already callsrelationship.get()for each relationship before reading its fields. This PR focuses narrowly on preventing the listing operation from failing when the optional field is still unavailable.Tests
Added unit tests covering:
policy, which should return"Type": Nonepolicy.type == "async", which should preserve"Type": "async"The tests use
SnapmirrorRelationship.from_dict()objects and mock network-dependent operations only.Limitations
This change has been validated with mock-based unit tests. It has not been integration-tested against a live ONTAP cluster.