Skip to content

ci: fix long build times (and other build improvements)#56

Merged
ErikBjare merged 5 commits into
NeuroTechX:masterfrom
ErikBjare:dev/ci-fixes
Dec 6, 2020
Merged

ci: fix long build times (and other build improvements)#56
ErikBjare merged 5 commits into
NeuroTechX:masterfrom
ErikBjare:dev/ci-fixes

Conversation

@ErikBjare

@ErikBjare ErikBjare commented Dec 6, 2020

Copy link
Copy Markdown
Collaborator

Continuing work on #54 to reduce build times and remove the need for the -e flag with pip install.

@ErikBjare ErikBjare changed the title fix: added __init__.py to eegnb/cli to fix find_packages() in setup.py ci: fix long build times (and other build improvements) Dec 6, 2020
@ErikBjare ErikBjare requested a review from jnaulty December 6, 2020 09:30
@ErikBjare

ErikBjare commented Dec 6, 2020

Copy link
Copy Markdown
Collaborator Author

Build times back down to 3min. Pretty confident this works now (still waiting for CI...) (edit: premature confidence, needed to touch a few more __init__.py into existence)

wxPython is still a mess for Linux users to install, so we might want to point them in the right direction so they don't waste a lot of time finding the wxPython wheels.

@ErikBjare

Copy link
Copy Markdown
Collaborator Author

Wooo, build passed in 3min! (down from the swindling 40min)

@ErikBjare

Copy link
Copy Markdown
Collaborator Author

I'll probably merge this as soon as CI passes, but key takeaways:

  • We need __init__.py in folders if they are to be detected by find_packages() (another pitch for build: moved to pyproject.toml/poetry #22 since it handles this better by supporting PEP420)
  • Installing wxPython on Linux is a mess, if you don't know where to find the wheels (so this should probably be documented somewhere)

@ErikBjare ErikBjare merged commit 55fdbd6 into NeuroTechX:master Dec 6, 2020
@ErikBjare ErikBjare deleted the dev/ci-fixes branch December 6, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant