adds server url template abnf - #4264
Conversation
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
ralfhandl
changed the title
|
After discussion in TDC we agreed that |
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
@handrews @char0n @ralfhandl I think we're ready for final review here :) |
ralfhandl
left a comment
ralfhandl
left a comment
There was a problem hiding this comment.
Align with https://www.rfc-editor.org/errata/eid6937
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
…r diverging future updates Signed-off-by: Vincent Biret <vibiret@microsoft.com>
char0n
left a comment
char0n
left a comment
There was a problem hiding this comment.
LGTM, I've tested it as well, compiles and parses correctly.
Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>
|
Random question- why does this PR start with "docs:"? It's a spec PR, not a docs PR. I keep overlooking it because of this. |
Muscle memory: on most repos I work on, we follow semantic commits. And usually when I touch Md files there, it's documentation. GitHub CLI: -f uses the first commit when creating a PR. |
baywet
changed the title
|
@baywet thank you for satisfying my curiosity! Yeah, this project is a little unusual in that the spec markdown is really the "source". "Docs" to me are things like CONTRIBUTING.md and the README. |
Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
I'm doing some final testing on extended test suite - will check back here when everything glows green. |
char0n
left a comment
char0n
left a comment
There was a problem hiding this comment.
LGTM, all tests on extended test-suite turned green
miqui
left a comment
miqui
left a comment
There was a problem hiding this comment.
looks good - discussed during TDC.
5 participants
partial #3256
related #4244