Conversation
…ing only by description Co-authored-by: seonwooj0810 <seonwooj0810@gmail.com>
Member
Author
|
CI failure (php-laravel) not related to this PR and will be addressed in another PR instead. |
Contributor
There was a problem hiding this comment.
1 issue found across 128 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/openapi3/client/petstore/python-pydantic-v1/tests/test_rest.py">
<violation number="1" location="samples/openapi3/client/petstore/python-pydantic-v1/tests/test_rest.py:25">
P0: Line 25 creates an `UploadFileWithAdditionalPropertiesRequestObject`, but line 30 passes it as `marker` to `test_object_for_multipart_requests`, which expects `TestObjectForMultipartRequestsRequestMarker`. These are distinct classes — the test will fail at runtime with a type/validation error.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| mock_resp.headers = {} | ||
|
|
||
| marker = petstore_api.TestObjectForMultipartRequestsRequestMarker( | ||
| marker = petstore_api.UploadFileWithAdditionalPropertiesRequestObject( |
Contributor
There was a problem hiding this comment.
P0: Line 25 creates an UploadFileWithAdditionalPropertiesRequestObject, but line 30 passes it as marker to test_object_for_multipart_requests, which expects TestObjectForMultipartRequestsRequestMarker. These are distinct classes — the test will fail at runtime with a type/validation error.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/openapi3/client/petstore/python-pydantic-v1/tests/test_rest.py, line 25:
<comment>Line 25 creates an `UploadFileWithAdditionalPropertiesRequestObject`, but line 30 passes it as `marker` to `test_object_for_multipart_requests`, which expects `TestObjectForMultipartRequestsRequestMarker`. These are distinct classes — the test will fail at runtime with a type/validation error.</comment>
<file context>
@@ -22,7 +22,7 @@ def test_multipart_requests(self):
mock_resp.headers = {}
- marker = petstore_api.TestObjectForMultipartRequestsRequestMarker(
+ marker = petstore_api.UploadFileWithAdditionalPropertiesRequestObject(
name="name",
)
</file context>
Suggested change
| marker = petstore_api.UploadFileWithAdditionalPropertiesRequestObject( | |
| marker = petstore_api.TestObjectForMultipartRequestsRequestMarker( |
3 tasks
wing328
added a commit
that referenced
this pull request
Jul 3, 2026
This was referenced Jul 3, 2026
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #24007
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Limit structural-signature deduplication to titled schemas so anonymous inline schemas that differ only by description are no longer merged. This prevents accidental type collapsing and generates distinct models where appropriate.
InlineModelResolver.matchGeneratedto apply structural-signature matching only to titled schemas; untitled inline schemas now remain distinct even if structurally identical after stripping volatile fields.FilterMust,FilterMustNot,PrefetchPrefetch,TrackerStatusOneOf1; updatedFilter.must/must_not,Prefetch.prefetch, andTrackerStatusto use them.TestEnumParametersEnumHeaderStringParameter; used for bothenum_header_stringandenum_query_string, updated converters,FakeApiparameter types, docs, and tests across GenericHost samples.python-httpx,python-httpx-sync,python-aiohttp,python-lazyImports,python-pydantic-v1-aiohttp): addedUploadFileWithAdditionalPropertiesRequestObject; updatedFakeApi.upload_file_with_additional_propertiesto use it, refreshed docs, and updated tests (including a unit test for the model inpython-httpx-sync).Written for commit d1d9c98. Summary will update on new commits.