Add JavaClientCodegen RxJava option tests#24203
Open
amirdeljouyi wants to merge 1 commit into
Open
Conversation
Member
|
thanks for the PR shall we simply remove/deprecate the RxJava2 option ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: add JavaClientCodegen processOpts coverage
Hi,
I added a couple of focused
processOpts()checks forJavaClientCodegen. They cover RxJava option normalization, including the case where RxJava 2 and 3 are both configured, and the explicitsupportUrlQueryconversion for the Apache client.The main covered areas are the RxJava handling at JavaClientCodegen.java:425-428 and the
supportUrlQueryconversion at JavaClientCodegen.java:512-518. Branch coverage forJavaClientCodegenincreases by about 2%.I hope you find these tests useful. 😄 Please let me know if you have any questions or concerns.
Thanks,
Amir
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Add unit tests for
JavaClientCodegen.processOptsto validate RxJava option handling andsupportUrlQueryconversion for the Apache client. Tests cover the case where both RxJava2 and RxJava3 are set (RxJava3 wins) and ensuresupportUrlQuerystring values convert to booleans; branch coverage increases ~2%.Written for commit 83cc8ca. Summary will update on new commits.