fix: Ambiguity between UPC-A and EAN-13#33
Merged
Conversation
OS-pedrogustavobilro
requested review from
ItsChaceD,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro and
eric-horodyski
and removed request for
a team
⛔ Snyk checks have failed. 7 issues have been found so far.
⛔ security/snyk check is complete. 7 issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) 💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
OS-ruimoreiramendes
approved these changes
Sep 4, 2025
alexgerardojacinto
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for hints, introduced in #31, contains some ambiguity in
UPC-AandEAN-13formats, which are very similar (visually they look similar, and both have 13 digits).There is no
.upcasymbiology in Apple Vision, so there is no way to distinguish if a scanned barcode is of formatUPC-AorEAN-13. What this PR does is check the provided hint, if a barcode of symbiology.ean13was scanned, if the hint used was.ean13or.upca, then that hint is returned as format.