Add Predator's Mark support (Pounce's ally-based DamageTaken curse)#2135
Open
mataide wants to merge 4 commits into
Open
Add Predator's Mark support (Pounce's ally-based DamageTaken curse)#2135mataide wants to merge 4 commits into
mataide wants to merge 4 commits into
Conversation
LocalIdentity
requested changes
Jun 8, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
We already calculate MinionPresenceCount in CalcPerform so that value should be used for the mod
| duration = true, | ||
| }, | ||
| statMap = { | ||
| ["skill_wolf_mark_damage_taken_+%_per_nearby_enemy"] = { |
Contributor
There was a problem hiding this comment.
Formatting of the mod is not consistent with other mods where we have it all on 1 line
| { breakdown = "ParryRangeProj" }, | ||
| { label = "Range modifiers", modName = "ParryRangeProj", cfg = "skill" }, | ||
| }, }, | ||
| -- Predator's Mark |
Contributor
There was a problem hiding this comment.
This stat doesn't need to exist imo. Maybe one for MinionPresenceCount would be ok though
Contributor
|
Changes to the lua gem files also need to have the same change in the txt file that generates them |
…t source - act_str.lua + act_str.txt: change AlliesInSummonerRange -> MinionPresenceCount, collapse mod() to single line per project convention, add txt source change - CalcPerform: read already-computed MinionPresenceCount from player modDB and bridge it to enemyDB (capped at 15); remove custom ConfigAlliesInSummonerRange - ConfigOptions: remove custom alliesInRange option; existing multiplierMinionsInPresence (# of Minions in your Presence) handles it - CalcSections: remove Predator's Mark Allies display row - TestSkills_spec: update to use multiplierMinionsInPresence config var Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Predator's Mark (
WolfPounceMarkPlayer), the hidden mark triggered by Pounce, had no PoB support. The skill causes the marked enemy to take increased damage based on the number of allies near it, but the stat was never mapped, no config option existed, and the gem tooltip showed the stat line as unsupported.This PR adds full support for Predator's Mark:
statMapinWolfPounceMarkPlayer: mapsskill_wolf_mark_damage_taken_+%_per_nearby_enemytoDamageTaken INC (Multiplier:AlliesInSummonerRange, GlobalEffect:Curse), and marks the cap stat as supported so the tooltip renders in green# of Allies in Range:(appears in Skill Options when Pounce is active; usesifEnemyMult = "AlliesInSummonerRange")CalcPerformhandler: reads the config value, caps it at 15 (since cap/rate = 45/3 = 15), and writes toenemyDB.multipliers["AlliesInSummonerRange"]; also setsoutput.PredatorsMarkAlliesfor the CalcSections rowPredator's Mark Alliesrow in the offence section, visible when Pounce is active and allies > 0Steps taken to verify a working solution:
# of Allies in Range:appears in Skill Options when Pounce is in the skill list, hidden otherwiseDamageTaken INCin CalcBreakdown (3% per ally at base, scales with quality)Predator's Mark Alliesrow is visible in the calcsTab offence section when Pounce is active and allies > 0TestSkills_spec.luacovering the scaling and capLink to a build that showcases this PR:
Add a Pounce gem to any Druid build, set
# of Allies in Range: 5in the Config tab → Skill Options, and observe the DamageTaken increase in the CalcBreakdown.