Skip to content

Fix crash when importing items with +1 suffix rune#2175

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
vaisest:7-mods
Jun 23, 2026
Merged

Fix crash when importing items with +1 suffix rune#2175
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
vaisest:7-mods

Conversation

@vaisest

@vaisest vaisest commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Fixes crash on 7 mod rares. Simply adds 3 more controls. This doesn't change how they're created and they are still made when itemsTab is initialised. I.e., this doesn't add support for an unlimited amount

Steps taken to verify a working solution:

  • Old items work as they used to
  • Testing with various +# prefix/suffix modifier allowed mods works
  • Real-world items tested work

Link to a build that showcases this PR:

Item Class: Bows
Rarity: Rare
Eagle Bane
Obliterator Bow
--------
Quality: +30% (augmented)
Physical Damage: 375-677 (augmented)
Lightning Damage: 8-215 (lightning)
Critical Hit Chance: 10.00% (augmented)
Attacks per Second: 1.31 (augmented)
--------
Requires: Level 78, 163 Dex
--------
Sockets: S S S 
--------
Item Level: 82
--------
+1 Suffix Modifier allowed (rune)
20% increased Physical Damage (rune)
Bow Attacks fire an additional Arrow (rune)
--------
{ Implicit Modifier }
50% reduced Projectile Range
--------
{ Prefix Modifier "Merciless" (Tier: 1) — Damage, Physical, Attack }
171(170-179)% increased Physical Damage
{ Prefix Modifier "Vapourising" (Tier: 1) — Damage, Elemental, Lightning, Attack }
Adds 8(1-12) to 215(202-234) Lightning Damage
{ Desecrated Prefix Modifier "Flaring" (Tier: 1) — Damage, Physical, Attack }
Adds 37(26-39) to 64(44-66) Physical Damage
{ Fractured Suffix Modifier "of Unmaking" (Tier: 1) — Attack, Critical }
+5(4.41-5)% to Critical Hit Chance
{ Suffix Modifier "of the Sniper" (Tier: 1) }
+4 to Level of all Projectile Skills
{ Suffix Modifier "of Many" (Tier: 1) — Attack }
+198(175-200)% Surpassing chance to fire an additional Arrow
{ Suffix Modifier "of Acclaim" (Tier: 1) — Attack, Speed }
19(17-19)% increased Attack Speed
--------
Fractured Item
--------
Hinekora's Lock
--------
Note: ~b/o 1 mirror

Before screenshot:

image

After screenshot:

image

@vaisest vaisest marked this pull request as draft June 12, 2026 17:30
@vaisest vaisest marked this pull request as ready for review June 12, 2026 17:32
@vaisest vaisest mentioned this pull request Jun 19, 2026
2 tasks
@vaisest vaisest added pob1 Should also be merged into PoB1 Repo crash Causes PoB to crash and is High Priority labels Jun 20, 2026
@LocalIdentity LocalIdentity changed the title Add more affix controls Fix crash when importing items with +1 suffix rune Jun 23, 2026

@LocalIdentity LocalIdentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to fix the import for items that have removed the +1 suffix mod from the item bit still retained the mod

@LocalIdentity LocalIdentity merged commit c1ffcf4 into PathOfBuildingCommunity:dev Jun 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crash Causes PoB to crash and is High Priority pob1 Should also be merged into PoB1 Repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants