Skip to content

Use app JWT for GitHub App endpoint checks#4

Merged
JWhitleyWork merged 1 commit into
mainfrom
fix/app-endpoint-jwt-auth
Jun 26, 2026
Merged

Use app JWT for GitHub App endpoint checks#4
JWhitleyWork merged 1 commit into
mainfrom
fix/app-endpoint-jwt-auth

Conversation

@marty-mcfly-bot

Copy link
Copy Markdown
Contributor

Summary

  • Use the GitHub App JWT, not the installation token, for GET /app checks
  • Keep installation tokens for repository/API calls
  • Add a regression test that app_request() authenticates with the app JWT
  • Bump the package version to 0.1.2

Verification

  • ruff format .
  • ruff check .
  • mypy
  • pytest
  • python -m build
  • python -m twine check dist/*
  • hermes-github-app doctor --repo PickNikRobotics/hermes_github_app_plugin using the configured app credentials

@JWhitleyWork JWhitleyWork self-requested a review June 26, 2026 20:20
@JWhitleyWork JWhitleyWork self-assigned this Jun 26, 2026
@JWhitleyWork JWhitleyWork enabled auto-merge (squash) June 26, 2026 20:21
@JWhitleyWork JWhitleyWork disabled auto-merge June 26, 2026 20:21
@JWhitleyWork JWhitleyWork merged commit d74f4d1 into main Jun 26, 2026
2 checks passed
@JWhitleyWork JWhitleyWork deleted the fix/app-endpoint-jwt-auth branch June 26, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant