Re-implement legacy readline support#1584
Merged
rjmholt merged 12 commits intoOct 15, 2021
Merged
Conversation
ghost
added
rjmholt
marked this pull request as ready for review
October 13, 2021 00:03
rjmholt
force-pushed
the
pt-legacy-readline
branch
3 times, most recently
from
October 14, 2021 17:13
42cb727 to
ee3af49
Compare
andyleejordan
approved these changes
Oct 14, 2021
SeeminglyScience
approved these changes
Oct 14, 2021
SeeminglyScience
left a comment
SeeminglyScience
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! One minor comment
rjmholt
force-pushed
the
pt-legacy-readline
branch
from
October 14, 2021 22:24
1214d10 to
43bddb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1436.
This PR: